percent-in could be improved and is buggy

[pterjan@…]

According to the code, the warning occurs when % appears in the scriptlet and %% does not. I th So, ink this is intended to trigger only unreplaced macros if they were intended.

So, the wanted behaviour would be :

• %foo in the spec, %foo in the script -> warning
• %%foo in the spec, %foo in the script -> OK

But the %% is looked for in the script so it will never appear and this part of the test is useless. Anyway it would not be optimal as %foo %%bar would not trigger the warning as the tests are separate.

Current behaviour is :

• %foo in the spec, %foo in the script -> warning
• %%foo in the spec, %foo in the script -> warning

[scop]

(Edited summary so it displays more understandably in Wiki)

[anonymous]

I'm using the following patch with some success.

[scop]

A slightly different implementation of this has been in already for a while, see e.g. #132 and some earlier commits.